Skip to content

[19.0][IMP] auth_api_key: neutralize API keys - #950

Merged
OCA-git-bot merged 1 commit into
OCA:19.0from
camptocamp:neutralize-auth_api_key
Jul 15, 2026
Merged

[19.0][IMP] auth_api_key: neutralize API keys#950
OCA-git-bot merged 1 commit into
OCA:19.0from
camptocamp:neutralize-auth_api_key

Conversation

@yankinmax

@yankinmax yankinmax commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Clear stored auth_api_key secrets during database neutralization.

@Ricardoalso Ricardoalso mentioned this pull request Jun 11, 2026
Merged
ivantodorovich
ivantodorovich reviewed Jun 11, 2026
View reviewed changes

@ivantodorovich ivantodorovich left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG overall

Comment thread test-requirements.txt Outdated
@yankinmax
yankinmax force-pushed the neutralize-auth_api_key branch from 5751015 to 2769e9f Compare June 12, 2026 06:32
@TDu

TDu commented Jun 12, 2026

Copy link
Copy Markdown
Member

It is already a feature in 18 https://github.com/OCA/server-auth/blob/18.0/auth_api_key/data/neutralize.sql should we not forward port ?

@yankinmax

yankinmax commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

It is already a feature in 18 https://github.com/OCA/server-auth/blob/18.0/auth_api_key/data/neutralize.sql should we not forward port ?

It's not exactly what we think about. @ivantodorovich what do you think?

@vvrossem

vvrossem commented Jun 12, 2026

Copy link
Copy Markdown

It is already a feature in 18 https://github.com/OCA/server-auth/blob/18.0/auth_api_key/data/neutralize.sql should we not forward port ?

🤔 this would benefit #949: key would remain required

@vvrossem vvrossem mentioned this pull request Jun 12, 2026
Closed
@ivantodorovich

This comment was marked as resolved.

Sign in to view
@yankinmax
yankinmax force-pushed the neutralize-auth_api_key branch from 2769e9f to b7b7c81 Compare June 15, 2026 07:25
ivantodorovich
ivantodorovich approved these changes Jun 16, 2026
View reviewed changes

@ivantodorovich ivantodorovich left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@OCA-git-bot

OCA-git-bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@ivantodorovich

ivantodorovich commented Jul 8, 2026

Copy link
Copy Markdown

@lmignon @etobella can we get your opinion on this? 🙏🏻

@etobella

etobella commented Jul 15, 2026

Copy link
Copy Markdown
Member

/ocabot merge patch

@OCA-git-bot

OCA-git-bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 19.0-ocabot-merge-pr-950-by-etobella-bump-patch, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit 5c0011e into OCA:19.0 Jul 15, 2026
7 checks passed
@OCA-git-bot

OCA-git-bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at d95fe76. Thanks a lot for contributing to OCA. ❤️

@ivantodorovich
ivantodorovich deleted the neutralize-auth_api_key branch July 22, 2026 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmignon lmignon lmignon approved these changes
@etobella etobella etobella approved these changes
+2 more reviewers
@ivantodorovich ivantodorovich ivantodorovich approved these changes
@Ricardoalso Ricardoalso Ricardoalso approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 mod:auth_api_key Module auth_api_key ready to merge series:19.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@yankinmax @TDu @vvrossem @ivantodorovich @OCA-git-bot @etobella @lmignon @Ricardoalso